Liens for New Horizon LEISA data sets (Dec 2016 peer review)
------------------------------------------------------------
* Last updated 2016-12-14 by SBN:T.Barnes and SBN:S.Protopapa

Certification Status: Certified, minor liens to resolve.


Issues with spectral resolving power and wavelength assignment. The lambda/delta-lambda from extension number 1 of the FITS file is what I used; this results in values of 220 and 425 for low- and high resolution segments and it is constant across the full wavelength range.  The obtained values are distinctly lower than those reported in the SSR (240 and 560 for the low resolution and high resolution segments respectively).  Furthermore as shown in REUTERETAL2008 the resolving power is not constant across the full wavelength range (see figure 8 in REUTERETAL2008).  Therefore extension 1 of the LEISA FITs data needs to be revised.  Specifically, the delta-lambda data in extension 1 needs to be corrected.

In the file 'introdoc.pdf' in the main LEISA folder, the resolving power is reported equal to 280 and 580 respectively.  These values are not in agreement with those reported in REUTERETAL2008 and need to be corrected.  

The '.../calib/initial/wavemap.fit' file is not in agreement with extension 1 of the LEISA FITs data.  It is indeed reversed with respect to what is expected. It looks like the wavemap is from an earlier calibration, but it should be updated and be made consistent with what's in extension 1 of the FITS files.

Missing a number of definitions for acronyms

Suggest for P3 delivery adding file that contains the list of the predicted center of target/location for the scans.  Or add scan direction and speed to labels.  To be discussed between Silvia P. and NH team.

From V1.0 to V2.0 of the PC data sets, the target changed from EARTH to STAR or N/A for some files.  Examples found in 'data/2007071*/'.  Double check that this is correct.    If they are correct, a note should be added to the dataset.cat file.


directory: 'calib/'
--> Remove the superseded calibration files.  Please only provide the current ones used for the current version of the data set.
--> Check orientation of all surviving calibrations files.

file: 'catalog/dataset.cat'
--> starting at line 47: "- Uranus with MVIC at phase angles not available from Earth " (and Neptune next line) what phase angles?
--> line 55 - what is SIA? (it is defined in line 76)
--> acronyms: CODMAC 

file: 'catalog/leisa.cat'
--> Some acronyms not defined: FOV,  MVIC TDI channels, IFOV, LVF, SSR1, CDH1 (likely more)
--> line 257: "The LEISA ApIDs, the algorithm, and whether the data are stored on SSR1 by CDH1 or on SSR2 by CDH 1 are shown in the following table:"  I assume they mean "SSR2 by CDH2" according to the table that follows this line.

files: 'data/*/*.lbl'
--> The BODY_POLE_CLOCK_ANGLE needs to be double checked.
--> typo (**emphasis** added): "Ephemeris time and quaternion **fo** each frame".  "fo" => "for"

file: 'document/leisa_window_pluto.csv'
--> This windowing summary csv file needs to be included in the pluto cruise data set as well.

file: 'document/leisa_window_pluto.lbl'
--> line 29: actual phase name wasn't inserted.  typo: "$(phaseUC)s"

file: 'document/ralph_ssr.pdf'
--> Reconcile quoted dispersion from REUTERETAL2008 with second plane of wavelength map extension (#1).  Figure 8 in SSR should be reproducible.  Check the delta wavelength in extension 1 of LEISA.  LEISA lien that may apply across the board.

file: 'document/samples/leisa_samples.lbl'
--> lines 71-80 are repetitive: (note this is true for all lbl files in the document/samples folder for all four LEISA datasets

file: 'document/stis_solar.lbl'
--> line 44: type "specturm" should be "spectrum" : Multiply by a target's geometric albedo specturm, and divide by r (AU;        

file: 'NOTES/introdoc.pdf'
--> line 1: "[instrument]" appears that it should be filled in with the appropriate instrument.
--> line 2: typo "here tfor"
--> Directory section line 4 typo: " SuBtracted". line 5: EDR and RDR acronyms not defined.
--> Data File contents acronyms EDU, ICD not defined.





General Liens for all New Horizon data sets (Dec 2016 peer review)
------------------------------------------------------------------
* Last updated 2016-12-14 by SBN:T.Barnes


Ensure that all PDF files are PDF/A-1a or PDF/A-1b compliant.


file: 'aareadme.txt'
--> Boiler Plate commands to pipeline not deleted: "skel_DELETE_BETWEEN_IF_INSTRUMENT_IS_rex"

file: 'catalog/dataset.cat'
--> Remember to update the 'Review" section in DATA_SET_DESC from TBD.
--> Several ABSTRACT_DESC are lacking or may be incomplete as compared to the rest of the data sets.  Ex: ALICE/PEPSSI/SDC PC and LORRI launch/jupiter/PC

file: 'catalog/nh.cat'
--> It is stated twice that the "spacecraft closest approaches were 13,678 kilometers ..." (also in mission phase section), but SPICE as currently available at NAIF gives 13,674 km.  Note the 13,678 vs 13,674.
--> "Mission phases and sub-phases in data products" uses sub-phases that are not defined "ACO#" "AP#" "DP#"
--> Under the Summary section, the 'Trajectory' description second line is not aligned with the first line.

file: 'catalog/nhsc.cat'
--> I prefer for wavelength ranges of instruments to be provided rather than just the general "visible" and "infrared" description.
--> Incomplete sentence: "Operational requirements for catalyst bed heater ..."  stops with "bed heater".

file: 'catalog/ref.cat'
--> Remove ITAR documents.
--> Note that not all data sets have the most current copy of this file.

file: 'document/aareadme_bu.txt'
--> Boiler Plate commands to pipeline not deleted: "skel_DELETE_BETWEEN_IF_INSTRUMENT_IS_rex"

file: 'document/docinfo.txt'
--> The quote/ditto (use of ") is a minor issue, but seems to have confused at least a few reviewers.
--> line 51:   3) SOC Instrument Interface Control Document (aka the 'ICD') => 1) and 2) provide the file name, it would be best to use the file name when possible. In this case: soc_inst_icd.pdf. Same applies for reference 4) on line 76.  This lien was for LEISA, but apply almost across the board.
--> typo: "backgound" => "background" near entry for "LUNINEETAL1995.PDF"

file: 'document/nh_mission_trajectory.lbl'
--> typo: "quantitities" => "quantities"
--> typo: "intrument" => "instrument"

file: 'document/nh_trajectory.tab'
--> nh_mission_trajectory.tab contains the trajectory of the whole mission, nh_trajectory.tab covers the first half of 2007 (Jupiter phase).  Suggest to remove the latter.  Mentioned as MVIC lien, but may apply for most other data sets.

file: 'document/soc_inst_icd.pdf'
--> pg iv TOC: The SDC hyperlinks do not work correctly.
--> pg 3, #5, 4th bullet: add **text**: "temp_dir - Location for temporary storage used by **the** code"
--> pg 54, table 10-2, 10-3: Data format not consistent with the specifications in these two tables.  This is probably a lack of clarity in the document description regarding bytes vs. fields.
--> pg 67, 10.3.6: Information outdated, and conflict with 10.3.13
--> section 11: There appears to be no description of ApIDs 0x695-0x698.  Are these included by mistake or do they need to described properly here and elsewhere?
--> pg 76, 11.1.2 par 1: Missing period at end of 3rd sentence, which ends in "Figure 11-3".
--> section 11.3: There should be a reference to Table 11-1.
--> pg 89, 11.4.1.2 par 0: typo: 'Through 2010, the typical' => 'The typical'
--> pg 104, 11.4.5.3.1: There is a problem with the equation here: "We could also write n' = n' += !  n'"  The '  ' is missing a character that does not print correctly.  It should be 'q'?
--> pg 127, 13.2.4: states to see section 115, but where is that?
--> pg 129, 13.3.1.1: The sentence "See for a plot of Charge vs DN represented by the Fit Coefficients." should reference the plot below, Figure 13-2
--> pg 130, 13.3.2.*: equations are formatted wrong ("Y" appears throughout the equation where there should be a symbol indicating multiplication)
--> pg 130, 13.3.2.1: hyperlink to ResearchGate.net not very helpful without more info on James et al 2010 paper.  
--> pg 134, 14.1, par 2: Sentence starts with "shows a cross section".
--> pg 135, 14-2: Caption correction (**changes**): "Diagram of New Horizons spacecraft **highlighting the location of the** SWAP instrument on the left.  On the right **is a ** diagram of the SWAP ..."
--> pg 136, 14.3: The summary data (0x585) from SWAP needs to be describe what product levels will exist and where.  Currently there is level 2 and expected to be level 4, but no level 3 data.
--> pg 136, 14.3 par 1: Suggest rewriting this section (**change**): "Housekeeping, messages, **summary,** and memory dump provide engineering data and the other *two* modes contain science data.  ... For **[delete science]** summary and science histogram modes, ...".  The last change happens twice in this paragraph.
--> pg 137, 14.3 par 3, last sentence: change "are not" -> "is" and add more details (**changes**): "The summary data 0x585 packet **is** included in the PDS SWAP data sets**; however, they are delivered as a level 2 product only.  It was found that the solar wind speed, density, and temperature provided in the summary packet were not adequate for science studies of the solar wind.  These values will be included in the PDS data set for SWAP as a Level 4 data product**." 
--> --> May want to make this change present tense since the products are expected to be reviewed shortly.
--> pg 140, 14.4.2 (**suggested changes**): "Summary packets are **[delete 'no longer']** included in the SWAP PDS delivered data sets**; however, they are delivered as a level 2 product only**."
--> pg 144, 14.5.4 par 1: combine second and third sentences: 'for the rates. The errors and include an error' => 'for the rates, and an error'
--> pg 145, 14.5.7 par 1: Add **text** to sentence as shown: "In the tail **of the Jupiter encounter,** the spacecraft is spinning so we ..."
--> pg 148, 14-10: In the caption, remove second 'of' from the sentence: "Two minutes of data set **of** measurements ..."
--> pg 153, 14-12: In the caption, remove the words 'in the' from the second sentence: "The y-axis **is in** the energy per charge."
--> pg 155, 14.9: Change underscore to whitespace: '(CEM)_detector' => '(CEM) detector'